A civilian cargo vessel has taken orders to carry a genetic modification centre but is unable to do so because its cargo hold is already full. It is now generating auto-turn-pausing interrupts because it cannot load. Presumably the underlying logic should not have allowed this so I'll file it as a bug. SM mode did not allow me to remove its orders nor empty its cargo so I have had to delete the vessel entirely instead.

Standard info dump:
- Conventional start
- Real stars
- US decimal and time formats (I have not reconfigured for UK standards)
- Approximately 85 years into the campaign
- Campaign started and running on v2.5.1 (no mods or DB edits ever)

I think I copied the code after fixing it.

Code duplication detected, billions must die. 

Quote from: Steve Walmsley on May 22, 2024, 06:16:33 AM

Yes, you are correct.

Here is the relevant code:
 

Code: [Select]

…
PossibleSystems = KnownSystems.Values.Except(CurrentSystems).OrderBy(x => Math.Pow(x.X - StartSystem.RealSystem.X, 2.0) + Math.Pow(x.Y - StartSystem.RealSystem.Y, 2.0) + Math.Pow(x.Z - StartSystem.RealSystem.Z, 2.0)).ToList();
…

The + should be -, as you stated above. Its been like this since C# launched and you are the first person to figure it out

I think correcting it is better than leaving as is, as it will be easier to understand what is happening.

Am I missing something? That looks like the right distance formula to me, with minus signs in the correct place.

As an aside, are you sure that you need to call ToList() there? OrderBy returns an IOrderedEnumerable, which you can directly enumerate over with a foreach loop. Calling ToList() will allocate a new List and copy the (sorted) elements into it. Then after the loop the List will be thrown away. Seems like wasted effort, but I have only a passing acquaintance with C# and could be wrong.

I think I copied the code after fixing it.

I need a temporary list because I don't want to modify the KnownSystems list.

Quote from: vorpal+5 on Yesterday at 12:57:15 AM

Is it the fleet commander's logistic used, or does each ship have its own schedule and speed based on the logistics of its captain?

I recall fleet members being un/loaded in series so every bonus for every ship helps. An unfortunate reality which sacrifices efficiency for reduced micromanagement. It would make me very happy to be proven wrong on this point so please do if able.

Get ready to be happy.
Ships in a fleet load in parallel, and the overall load/unload time of the fleet is just the maximum time of any single ship in the fleet.
Ship commanders only modify the time for their own ship.
Therefore, in a fleet where all the ships have the same unmodified load/unload time, the net time bonus will be based on the ship commander with the smallest logistics bonus (and other bonus sources, as usual).

I believe this along with the "advanced" beam weapon variants from the VB6 days are no longer in the game, although they can be added with some light DB modding.